package com.combatbarrier.managers; import com.combatbarrier.CombatBarrierPlugin; import net.kyori.adventure.text.serializer.legacy.LegacyComponentSerializer; import org.bukkit.*; import org.bukkit.block.data.BlockData; import org.bukkit.entity.Player; import org.bukkit.scheduler.BukkitTask; import java.util.*; /** * Sends fake BARRIER blocks to combat-tagged players via sendBlockChange(). * * Key design points: * - Blocks are client-side only (sendBlockChange is a packet, not a real block). * Other players cannot see or collide with them. * - BARRIER_DATA is a static final constant; Material.createBlockData() is * never called inside a loop. * - Config values are read once per player per tick, not per block. * - VOID_AIR and CAVE_AIR are both treated as passable (in addition to AIR). */ public final class BarrierManager { // Pre-built block data — avoids allocating a new object every tick. private static final BlockData BARRIER_DATA = Material.BARRIER.createBlockData(); private final CombatBarrierPlugin plugin; /** UUID → set of block locations currently shown as fake barriers to that player. */ private final Map> shown = new HashMap<>(); private BukkitTask updateTask; public BarrierManager(CombatBarrierPlugin plugin) { this.plugin = plugin; } // ------------------------------------------------------------------------- // Lifecycle // ------------------------------------------------------------------------- public void startTask() { int ticks = Math.max(1, plugin.getConfig().getInt("barrier.update-ticks", 2)); updateTask = plugin.getServer().getScheduler() .runTaskTimer(plugin, this::tick, ticks, ticks); } public void stopTask() { if (updateTask != null) { updateTask.cancel(); updateTask = null; } } /** Called on /cb reload — removes existing barriers then restarts the task. */ public void reload() { stopTask(); removeAllBarriers(); startTask(); } // ------------------------------------------------------------------------- // Main update tick (runs on main thread, every N ticks) // ------------------------------------------------------------------------- private void tick() { for (Player player : Bukkit.getOnlinePlayers()) { if (plugin.getCombatManager().isInCombat(player)) { updatePlayer(player); } else if (shown.containsKey(player.getUniqueId())) { removeBarriersForPlayer(player); } } } private void updatePlayer(Player player) { // Read config once — not inside any inner loop. int thickness = plugin.getConfig().getInt("barrier.thickness", 2); int height = plugin.getConfig().getInt("barrier.height", 4); double detectDist = plugin.getConfig().getDouble("barrier.detection-distance", 1.0); boolean particles = plugin.getConfig().getBoolean("barrier.particles", true); boolean playSound = plugin.getConfig().getBoolean("barrier.sound", true); Location origin = player.getLocation().toBlockLocation(); boolean inSafe = plugin.getZoneManager().isSafeZoneForPlayer(origin, player); // Collect the barrier block positions that should be shown this tick. Set next = new HashSet<>(); int scanRadius = (int) Math.ceil(detectDist) + thickness + 1; for (int dx = -scanRadius; dx <= scanRadius; dx++) { for (int dz = -scanRadius; dz <= scanRadius; dz++) { Location col = origin.clone().add(dx, 0, dz); boolean colInSafe = plugin.getZoneManager().isSafeZone(col); // Only columns that are on the other side of the border matter. if (colInSafe == inSafe) continue; double dist = Math.sqrt(dx * (double) dx + dz * (double) dz); if (dist > detectDist + thickness) continue; // Add a vertical strip at this (col.x, col.z). int baseY = origin.getBlockY(); for (int dy = -1; dy < height - 1; dy++) { Location bLoc = col.clone(); bLoc.setY(baseY + dy); Material mat = bLoc.getBlock().getType(); // Only place fake barriers where no solid block already exists. if (mat == Material.AIR || mat == Material.CAVE_AIR || mat == Material.VOID_AIR) { next.add(bLoc); } } } } Set prev = shown.getOrDefault(player.getUniqueId(), Collections.emptySet()); // Remove barriers that are no longer needed. for (Location loc : prev) { if (!next.contains(loc)) { player.sendBlockChange(loc, loc.getBlock().getBlockData()); } } // Send new barriers. boolean anyNew = false; for (Location loc : next) { if (!prev.contains(loc)) { player.sendBlockChange(loc, BARRIER_DATA); if (particles) { spawnParticle(player, loc); } anyNew = true; } } // Update the shown map. if (next.isEmpty()) { shown.remove(player.getUniqueId()); } else { shown.put(player.getUniqueId(), next); } // Notify the player the first time new barrier blocks appear this cycle. if (anyNew) { notifyPlayer(player, playSound); } } // ------------------------------------------------------------------------- // Cleanup helpers // ------------------------------------------------------------------------- /** Removes all fake barrier blocks for one player and cleans up the map. */ public void removeBarriersForPlayer(Player player) { Set locs = shown.remove(player.getUniqueId()); if (locs == null) return; for (Location loc : locs) { player.sendBlockChange(loc, loc.getBlock().getBlockData()); } } /** Removes all fake barrier blocks for every online player. Called on disable/reload. */ public void removeAllBarriers() { for (Player player : Bukkit.getOnlinePlayers()) { removeBarriersForPlayer(player); } shown.clear(); } // ------------------------------------------------------------------------- // Helpers // ------------------------------------------------------------------------- private void notifyPlayer(Player player, boolean playSound) { int remaining = plugin.getCombatManager().getRemainingSeconds(player); String raw = plugin.getConfig().getString( "messages.combat-barrier-hit", "&cYou cannot enter a safe zone while in combat! &7(&e%time%s remaining&7)"); String text = raw.replace("%time%", String.valueOf(remaining)); player.sendActionBar( LegacyComponentSerializer.legacyAmpersand().deserialize(text)); if (playSound) { playBarrierSound(player); } } private void playBarrierSound(Player player) { try { String key = plugin.getConfig() .getString("barrier.sound-type", "block.glass.break") .toLowerCase(Locale.ROOT) .replace("_", "."); // accept either format from config Sound snd = Registry.SOUNDS.get(NamespacedKey.minecraft(key)); if (snd != null) { player.playSound(player.getLocation(), snd, 0.6f, 1.2f); } } catch (Exception e) { if (plugin.isDebug()) { plugin.getLogger().warning("[CB] Sound playback error: " + e.getMessage()); } } } private void spawnParticle(Player player, Location loc) { Particle.DustOptions dust = new Particle.DustOptions(Color.RED, 1.0f); // Centre the particle in the block and add slight spread. player.spawnParticle( Particle.DUST, loc.clone().add(0.5, 0.5, 0.5), 3, // count 0.15, 0.15, 0.15, dust); } }